test: mark test-worker-eventlooputil flaky #35886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MylesBorins
added
flaky-test
|
Can we please fast-track to fix CI? |
github-actions
bot
removed
the
request-ci
gireeshpunathil
approved these changes
Oct 30, 2020
This is consistently failing in CI right now. Lets mark it flaky while we figure out what is going on. Refs: nodejs#35844
MylesBorins
force-pushed
the
mark-test-worker-eventlooputil-flaky
branch
from
6f2bb4a
to
5b7b0b1
Compare
github-actions
bot
removed
the
request-ci
Qard
approved these changes
Oct 30, 2020
Trott
reviewed
Oct 30, 2020
Comment on lines
8
to
+9
| test-http2-respond-file-error-pipe-offset: PASS,FLAKY | ||
| test-worker-eventlooputil: PASS,FLAKY |
There was a problem hiding this comment.
Please include the GitHub issue for that test in a comment above. Same for the entry above that, as it was missed in the fast-track PR.
Suggested change
| test-http2-respond-file-error-pipe-offset: PASS,FLAKY | |
| test-worker-eventlooputil: PASS,FLAKY | |
| # https://github.com/nodejs/node/issues/35881 | |
| test-http2-respond-file-error-pipe-offset: PASS,FLAKY | |
| # https://github.com/nodejs/node/issues/35844 | |
| test-worker-eventlooputil: PASS,FLAKY |
|
I know I already approved this, but are we sure we want to do this? This is a recently added test for a recently added feature that has not gone out in any release. The failures may indicate that the feature is not ready for release. It may be the case that a revert is in order. But if we mark it as flaky, no one will notice and no one will care. |
|
I'm all for a revert or a fix as soon as we can manage it, but a temporary flaky mark would be nice to unblock the CI as currently almost every run is failing. |
rickyes
approved these changes
Oct 31, 2020
|
+1 for temporary flake status.
if it does not work out well, I will update and we can revisit the decision? |
|
Since only freebsd appears to be affected, the flaky designation should be moved there rather than the "all" section? |
|
I'm not blocking since no one else seems to agree strongly with the concerns I'm raising. I'm conflicted myself. I can see it both ways. I mean, I did approve this, after all. Either way, I would encourage folks to look at #35891 if they haven't already. A fix! (Possibly.) |
gireeshpunathil
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in c0af8bd...915a94c |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 31, 2020
This is consistently failing in CI right now. Lets mark it flaky while we figure out what is going on. Refs: #35844 PR-URL: #35886 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
This is consistently failing in CI right now. Lets mark it flaky while we figure out what is going on. Refs: #35844 PR-URL: #35886 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 4, 2020
The active worker check compared the time from sending message till response arrived from worker with the complete time the worker was running till it responses to the spin request. If sending back the message is slow for some reason the test fails. Adapt the test to compare the time seen inside the worker with the time read from main thread. PR-URL: #35891 Fixes: #35844 Refs: #35886 Refs: #35664 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 4, 2020
The active worker check compared the time from sending message till response arrived from worker with the complete time the worker was running till it responses to the spin request. If sending back the message is slow for some reason the test fails. Adapt the test to compare the time seen inside the worker with the time read from main thread. PR-URL: #35891 Fixes: #35844 Refs: #35886 Refs: #35664 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
This is consistently failing in CI right now. Lets mark it flaky while we figure out what is going on. Refs: #35844 PR-URL: #35886 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
This is consistently failing in CI right now. Lets mark it flaky while we figure out what is going on. Refs: #35844 PR-URL: #35886 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
This is consistently failing in CI right now. Lets mark it flaky while we figure out what is going on. Refs: #35844 PR-URL: #35886 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Feb 1, 2021
The active worker check compared the time from sending message till response arrived from worker with the complete time the worker was running till it responses to the spin request. If sending back the message is slow for some reason the test fails. Adapt the test to compare the time seen inside the worker with the time read from main thread. PR-URL: nodejs#35891 Fixes: nodejs#35844 Refs: nodejs#35886 Refs: nodejs#35664 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: nodejs#37165
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Feb 1, 2021
The active worker check compared the time from sending message till response arrived from worker with the complete time the worker was running till it responses to the spin request. If sending back the message is slow for some reason the test fails. Adapt the test to compare the time seen inside the worker with the time read from main thread. PR-URL: nodejs#35891 Fixes: nodejs#35844 Refs: nodejs#35886 Refs: nodejs#35664 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: nodejs#37163
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Feb 10, 2021
The active worker check compared the time from sending message till response arrived from worker with the complete time the worker was running till it responses to the spin request. If sending back the message is slow for some reason the test fails. Adapt the test to compare the time seen inside the worker with the time read from main thread. PR-URL: nodejs#35891 Fixes: nodejs#35844 Refs: nodejs#35886 Refs: nodejs#35664 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: nodejs#37165
richardlau
pushed a commit
that referenced
this pull request
Mar 2, 2021
The active worker check compared the time from sending message till response arrived from worker with the complete time the worker was running till it responses to the spin request. If sending back the message is slow for some reason the test fails. Adapt the test to compare the time seen inside the worker with the time read from main thread. PR-URL: #35891 Fixes: #35844 Refs: #35886 Refs: #35664 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: #37163
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Mar 2, 2021
The active worker check compared the time from sending message till response arrived from worker with the complete time the worker was running till it responses to the spin request. If sending back the message is slow for some reason the test fails. Adapt the test to compare the time seen inside the worker with the time read from main thread. PR-URL: nodejs#35891 Fixes: nodejs#35844 Refs: nodejs#35886 Refs: nodejs#35664 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: nodejs#37165
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Mar 2, 2021
The active worker check compared the time from sending message till response arrived from worker with the complete time the worker was running till it responses to the spin request. If sending back the message is slow for some reason the test fails. Adapt the test to compare the time seen inside the worker with the time read from main thread. PR-URL: nodejs#35891 Fixes: nodejs#35844 Refs: nodejs#35886 Refs: nodejs#35664 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: nodejs#37165
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Mar 8, 2021
The active worker check compared the time from sending message till response arrived from worker with the complete time the worker was running till it responses to the spin request. If sending back the message is slow for some reason the test fails. Adapt the test to compare the time seen inside the worker with the time read from main thread. PR-URL: nodejs#35891 Fixes: nodejs#35844 Refs: nodejs#35886 Refs: nodejs#35664 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: nodejs#37165
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Mar 8, 2021
The active worker check compared the time from sending message till response arrived from worker with the complete time the worker was running till it responses to the spin request. If sending back the message is slow for some reason the test fails. Adapt the test to compare the time seen inside the worker with the time read from main thread. PR-URL: nodejs#35891 Fixes: nodejs#35844 Refs: nodejs#35886 Refs: nodejs#35664 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: nodejs#37165
richardlau
pushed a commit
to juanarbol/node
that referenced
this pull request
Mar 16, 2021
The active worker check compared the time from sending message till response arrived from worker with the complete time the worker was running till it responses to the spin request. If sending back the message is slow for some reason the test fails. Adapt the test to compare the time seen inside the worker with the time read from main thread. PR-URL: nodejs#35891 Fixes: nodejs#35844 Refs: nodejs#35886 Refs: nodejs#35664 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: nodejs#37165
MylesBorins
pushed a commit
that referenced
this pull request
Apr 6, 2021
The active worker check compared the time from sending message till response arrived from worker with the complete time the worker was running till it responses to the spin request. If sending back the message is slow for some reason the test fails. Adapt the test to compare the time seen inside the worker with the time read from main thread. PR-URL: #35891 Fixes: #35844 Refs: #35886 Refs: #35664 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: #37163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistently failing in CI right now. Lets mark it flaky
while we figure out what is going on.
Refs: #35844